-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixrule(aria_hidden_nontabbable) improve group message #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philljenkins
changed the title
improve group msg in rule and baselines
fixrule(aria_hidden_nontabbable) improve group message
Jun 22, 2023
shunguoy
previously approved these changes
Jun 23, 2023
shunguoy
approved these changes
Jun 29, 2023
@shunguoy Why shouldn't the baseline files be checked in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rule/Engine updates:
fixrule(
ruleid
): improve group msg in rule and baselinesThis PR is related to the following issue(s):
Additional information can be found here:
message:
"group": "A focusable element should not be within the subtree of an element with 'aria-hidden' set to \"true\"",
changed to:
"group": "A hidden element should not contain any tabbable elements",
Testing reference:
test/v2/checker/accessibility/rules/aria_hidden_notabbale_ruleunit/*
I have conducted the following for this PR: